-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add handling of updates to default values to the CRD Upgrade Safety preflight check #950
Add handling of updates to default values to the CRD Upgrade Safety preflight check #950
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor nit!
test/e2e/preflight_crdupgradesafety_invalid_field_change_default_added_test.go
Show resolved
Hide resolved
test/e2e/preflight_crdupgradesafety_valid_field_change_default_no_change_test.go
Show resolved
Hide resolved
@rashmigottipati Since I merged the other PR, this now has some merge conflicts. |
…reflight check Signed-off-by: Rashmi Gottipati <[email protected]>
97a2589
to
9a9d23d
Compare
Thanks @everettraven for the approval! @praveenrewar Thanks for merging the other PR. Rebased this PR and squashed commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@praveenrewar merge away if you are fine with this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What this PR does / why we need it:
This PR adds another field change validation to the CRD Upgrade Safety checks to prevent changes to a field's default values for a given CRD version during an upgrade and ensures the below:
Which issue(s) this PR fixes:
#949
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: