-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extra output in bash completion #592
Conversation
Currently we are using SetOutput which also sets the errWriter and is also deprecated
9ba9ef3
to
971a987
Compare
why do we need to special case this? wouldnt all of these commands (case "help", cobra.ShellCompRequestCmd, cobra.ShellCompNoDescRequestCmd) be running in non-tty env, so |
These commands are a bit special, quoting from the issue itself:
So, right now when we decide which commands should have the default tty behaviour and which should not have it, these commands are not even added to the command tree 😞 |
971a987
to
6a86b8a
Compare
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cobrautil path looks much cleaner!
LGTM 🚀
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #583
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: