When 2 images with same SHA are reference by 2 nested bundles #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are 2 nested bundles that reference the same image (AKA the same SHA) these images are considered as separated images internally. This behavior causes problems when imgpkg is trying to create the Locations image because it searches for the images by SHA, creating a dupplicated entry. To fix this we decided to force imgpkg to select only one of the entries to add to the Locations list. This could be averted as well if we stored only 1 copy of these images in the UnprocessedImagesRef struct the main issue is that this is going to hide from imgpkg that the same image is referenced from 2 different sources, this might cause problems in the long run, specially if one day we decide to implement the ability for users to copy bundles to different locations in the destination repository. Signed-off-by: Joao Pereira <[email protected]>
joaopapereira
temporarily deployed
to
TanzuNet Registry Dev e2e
GitHub Actions
Inactive
joaopapereira
temporarily deployed
to
GCR e2e
GitHub Actions
Inactive
praveenrewar
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are 2 nested bundles that reference the same image (AKA the same SHA) these images are considered as separated images internally. This behavior causes problems when imgpkg is trying to create the Locations image because it searches for the images by SHA, creating a dupplicated entry.
To fix this we decided to force imgpkg to select only one of the entries to add to the Locations list.
This could be averted as well if we stored only 1 copy of these images in the UnprocessedImagesRef struct the main issue is that this is going to hide from imgpkg that the same image is referenced from 2 different sources, this might cause problems in the long run, specially if one day we decide to implement the ability for users to copy bundles to different locations in the destination repository.