Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a bundle or image directly as a tar file #273

Closed
wants to merge 9 commits into from
Closed

Create a bundle or image directly as a tar file #273

wants to merge 9 commits into from

Conversation

DennisDenuto
Copy link
Contributor

@DennisDenuto DennisDenuto commented Oct 11, 2021 •
edited
Loading

Attempts to implement: #55

TODO:

  • manual test spike and ensure it works writing to a tarball directly not requiring a registry
  • look into providing a registry that can serve local images and images from the registry as an alternate way to implement this story
  • throw spike away and TDD implementation
  • consider whether a new command is needed "build" or whether this is part of the "push" command

Authored-by: Dennis Leon [email protected]

@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 11, 2021 23:37 Failure
@DennisDenuto DennisDenuto force-pushed the create-image-to-tar-55 branch from 88f862f to f3e1685 Compare October 11, 2021 23:43
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 11, 2021 23:43 Failure
@DennisDenuto DennisDenuto force-pushed the create-image-to-tar-55 branch from f3e1685 to 7ee180e Compare October 11, 2021 23:47
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 11, 2021 23:47 Failure
@DennisDenuto DennisDenuto force-pushed the create-image-to-tar-55 branch from 7ee180e to 3dc3bed Compare October 11, 2021 23:48
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 11, 2021 23:48 Failure
@DennisDenuto DennisDenuto force-pushed the create-image-to-tar-55 branch from 3dc3bed to 109fbfc Compare October 11, 2021 23:49
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 11, 2021 23:49 Failure
@DennisDenuto DennisDenuto force-pushed the create-image-to-tar-55 branch from 109fbfc to f87924a Compare October 14, 2021 00:26
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 14, 2021 00:26 Failure
@DennisDenuto DennisDenuto force-pushed the create-image-to-tar-55 branch from f87924a to 01597b7 Compare October 14, 2021 00:27
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 14, 2021 00:27 Failure
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 18, 2021 23:32 Failure
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 18, 2021 23:45 Failure
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 18, 2021 23:54 Failure
@DennisDenuto DennisDenuto force-pushed the create-image-to-tar-55 branch from 744efa7 to 4cc0463 Compare October 19, 2021 00:08
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 19, 2021 00:08 Failure
@DennisDenuto
ux: print correct number of images exported from imageset
f844b70 
Authored-by: Dennis Leon <[email protected]>
@DennisDenuto
refactor
6f03203 
- update receiveer name

Authored-by: Dennis Leon <[email protected]>
@DennisDenuto
Add test to ensure tags are preserved when written to tar / copied to
4960295 
repo

Authored-by: Dennis Leon <[email protected]>
@DennisDenuto
refactor:
cac250f 
- share IncludeNonDistributableFlag in copy.go + build.go

Authored-by: Dennis Leon <[email protected]>

refactor:

move public build function with other public functions

backfill Build test

Authored-by: Dennis Leon <[email protected]>
@DennisDenuto
ux: print out digest of the image built
2e80c1b 
Authored-by: Dennis Leon <[email protected]>
@DennisDenuto
feat: build command also writes signatures into tarball
b6258c5 
refactor:
- pass ui with prefix into build bundle and build image
- Add godocs
test refactor:
- build_test uses --cosign-sig flag when building and asserting signatures
- build_test uses nested test structure

Authored-by: Dennis Leon <[email protected]>
@DennisDenuto DennisDenuto force-pushed the create-image-to-tar-55 branch from 3a06e5c to b6258c5 Compare October 20, 2021 16:35
@DennisDenuto DennisDenuto temporarily deployed to GCR e2e October 20, 2021 16:35 Inactive
@DennisDenuto DennisDenuto temporarily deployed to TanzuNet Registry Dev e2e October 20, 2021 16:35 Inactive
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 20, 2021 17:14 Failure
@DennisDenuto DennisDenuto force-pushed the create-image-to-tar-55 branch from a50843e to 93e0bf4 Compare October 20, 2021 17:15
@DennisDenuto DennisDenuto had a problem deploying to TanzuNet Registry Dev e2e October 20, 2021 17:15 Failure
@DennisDenuto DennisDenuto force-pushed the create-image-to-tar-55 branch from 93e0bf4 to c6fb69d Compare October 20, 2021 17:18
@DennisDenuto DennisDenuto temporarily deployed to GCR e2e October 20, 2021 17:18 Inactive
@DennisDenuto DennisDenuto temporarily deployed to TanzuNet Registry Dev e2e October 20, 2021 17:18 Inactive
@DennisDenuto
Refactor:
da9fb85 
- Remove stuttering of IncludeNonDistributableFlag.IncludeNonDistributableFlag
- Add test to assert building an image with IncludeNonDistributableFlag

Authored-by: Dennis Leon <[email protected]>
@DennisDenuto DennisDenuto force-pushed the create-image-to-tar-55 branch from c6fb69d to da9fb85 Compare October 20, 2021 18:03
@DennisDenuto DennisDenuto temporarily deployed to TanzuNet Registry Dev e2e October 20, 2021 18:03 Inactive
@DennisDenuto DennisDenuto temporarily deployed to GCR e2e October 20, 2021 18:03 Inactive
@DennisDenuto DennisDenuto marked this pull request as ready for review October 20, 2021 19:13
@pivotaljohn pivotaljohn mentioned this pull request Nov 2, 2021
Open
@cppforlife
Copy link
Contributor

we'll try to rework based on #55 (comment)

@cppforlife
Copy link
Contributor

per discussion with dennis, will close. not sure if above proposed solution will result in some code reuse from this PR.

@cppforlife cppforlife closed this Nov 9, 2021
@joaopapereira joaopapereira deleted the create-image-to-tar-55 branch March 27, 2023 20:26
@parteekcoder
Copy link

@cppforlife I want to work on Package Repository to tar this project but does not know where can i start from. I saw this PR which relates to this project.

Could you please help me

@github-actions github-actions bot added the carvel triage This issue has not yet been reviewed for validity label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cppforlife cppforlife Awaiting requested review from cppforlife

Assignees
No one assigned
Labels
carvel triage This issue has not yet been reviewed for validity cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DennisDenuto @cppforlife @parteekcoder @vmwclabot