cve_feed: manage http request and add request log #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Khanh Le Do <[email protected]>
Signed-off-by: Khanh Le Do <[email protected]>
Signed-off-by: Khanh Le Do <[email protected]>
Signed-off-by: Khanh Le Do <[email protected]>
kledo-lyft
force-pushed
the
cve-feed-memory-debug
branch
from
0367e6e to
de77c8c
Compare
cmm-lyft
suggested changes
Dec 13, 2024
Comment on lines
+98
to
+99
| logger.error( | ||
| f"Failed to get CVE data from NIST NVD API {res.status_code} : {res.text}", |
There was a problem hiding this comment.
I don't think the spikes of memory are falling in this exception case.
Spikes are not raising an explicit HTTP exception, instead a runtime one (I guess, but I haven't find any logs from kibana / OpenSearch).
There was a problem hiding this comment.
discussing offline since it's related to Lyft
achantavy
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Turn on "Hide whitespaces" to review
Summary
We got some memory problem recently especially after NVD API becomes more unstable and retries are more often. This change attempts to reduce the memory leak while many requests are created, also logging the requests to help debug easier as there might be more improvements needed for this to work nicer.
requests.getcall to use a context manager (withstatement) to ensure the response is properly closed after use.