nonetype handling for repo collaborators #1405
Conversation
|
I did this very quickly just now and haven't had a chance to sanity check it on my real graph. Also have not added / updated tests. |
|
I had a small pocket of time at my desk so I wanted to share some sanity checks / screen caps, similar to the ones from original PR (#1391) where this issue was introduced. This should demonstrate the feature (identifying direct vs outside collabs) and that it is still working as expected, especially on top of the existing integration tests still working. Example repo with an outside collab(note this will look different from the similar screencap in the original PR because we've done cleanup of some of the users) Example repo with direct collabs
Counts to give a sense of all the connections in our graph
|
danbrauer
force-pushed
the
gh_repo_collabs_none_handling
branch
2 times, most recently
from
17e5d38 to
468a0da
Compare
|
@achantavy this is now updated with new unit testing. It should be good to go, but, I raced through this in tiny pockets of time. |
Signed-off-by: Daniel Brauer <[email protected]>
danbrauer
force-pushed
the
gh_repo_collabs_none_handling
branch
from
468a0da to
1ba368b
Compare
…tors sync (#1406) ### Summary Fix for #1404. Made this as a separate PR from #1405 since I can't push up to the etsy fork. ### Related issues or links - #1404 ### Checklist Provide proof that this works (this makes reviews move faster). Please perform one or more of the following: - [x] Update/add unit or integration tests. - [x] Include a screenshot showing what the graph looked like before and after your changes. - [ ] Include console log trace showing what happened before and after your changes. **Not applicable** If you are changing a node or relationship: - [ ] Update the [schema](https://github.com/lyft/cartography/tree/master/docs/root/modules) and [readme](https://github.com/lyft/cartography/blob/master/docs/schema/README.md). **Not applicable** If you are implementing a new intel module: - [ ] Use the NodeSchema [data model](https://cartography-cncf.github.io/cartography/dev/writing-intel-modules.html#defining-a-node). --------- Signed-off-by: Daniel Brauer <[email protected]> Co-authored-by: Daniel Brauer <[email protected]>
|
Closing this PR since its changes got recreated by Alex over in #1406 |
Summary
Fix for #1404
Related issues or links
Checklist
Provide proof that this works (this makes reviews move faster). Please perform one or more of the following:
Not applicable If you are changing a node or relationship:
Not applicable If you are implementing a new intel module: