Update the documentation reference #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emmanuel Ferdman <[email protected]>
chandanchowdhury
requested changes
Sep 25, 2024
|
Hey @emmanuel-ferdman good catch, thank you! @achantavy Should these links point to Docs site or MD files in Github? https://github.com/lyft/cartography/blob/master/docs/root/usage/drift-detect.md |
|
Let's point to the GH page: https://lyft.github.io/cartography/usage/drift-detect.html (When we complete the CNCF donation and move the GH org we'll have to redo all those links but that's a problem for the future) |
Signed-off-by: Emmanuel Ferdman <[email protected]>
|
@chandanchowdhury @achantavy updated the PR. Thanks for the review |
chandanchowdhury
previously requested changes
Sep 26, 2024
|
There's something weird going on with the CI, I'll ask for help |
auto-merge was automatically disabled
September 26, 2024 16:26
Pull request was closed
achantavy
dismissed
chandanchowdhury’s stale review
lets use the gh page url
danbrauer
pushed a commit
to etsy/cartography
that referenced
this pull request
Oct 31, 2024
### Summary PR cartography-cncf#248 moved the location of `drift-detect.md`. This PR adjusts source to point to: https://lyft.github.io/cartography/usage/drift-detect.html ### Related issues or links ### Checklist Provide proof that this works (this makes reviews move faster). Please perform one or more of the following: - [ ] Update/add unit or integration tests. - [ ] Include a screenshot showing what the graph looked like before and after your changes. - [ ] Include console log trace showing what happened before and after your changes. If you are changing a node or relationship: - [ ] Update the [schema](https://github.com/lyft/cartography/tree/master/docs/root/modules) and [readme](https://github.com/lyft/cartography/blob/master/docs/schema/README.md). If you are implementing a new intel module: - [ ] Use the NodeSchema [data model](https://lyft.github.io/cartography/dev/writing-intel-modules.html#defining-a-node). --------- Signed-off-by: Emmanuel Ferdman <[email protected]> Signed-off-by: Daniel Brauer <[email protected]>
chandanchowdhury
pushed a commit
to chandanchowdhury/cartography
that referenced
this pull request
Nov 27, 2024
### Summary PR cartography-cncf#248 moved the location of `drift-detect.md`. This PR adjusts source to point to: https://lyft.github.io/cartography/usage/drift-detect.html ### Related issues or links ### Checklist Provide proof that this works (this makes reviews move faster). Please perform one or more of the following: - [ ] Update/add unit or integration tests. - [ ] Include a screenshot showing what the graph looked like before and after your changes. - [ ] Include console log trace showing what happened before and after your changes. If you are changing a node or relationship: - [ ] Update the [schema](https://github.com/lyft/cartography/tree/master/docs/root/modules) and [readme](https://github.com/lyft/cartography/blob/master/docs/schema/README.md). If you are implementing a new intel module: - [ ] Use the NodeSchema [data model](https://lyft.github.io/cartography/dev/writing-intel-modules.html#defining-a-node). --------- Signed-off-by: Emmanuel Ferdman <[email protected]> Signed-off-by: chandanchowdhury <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR #248 moved the location of
drift-detect.md. This PR adjusts source to point to: https://lyft.github.io/cartography/usage/drift-detect.htmlRelated issues or links
Checklist
Provide proof that this works (this makes reviews move faster). Please perform one or more of the following:
If you are changing a node or relationship:
If you are implementing a new intel module: