Fix #689: correctly pass job name to GraphStatement #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heryxpc
approved these changes
Sep 18, 2024
chandanchowdhury
pushed a commit
to chandanchowdhury/cartography
that referenced
this pull request
Nov 27, 2024
…artography-cncf#1355) ### Summary > Describe your changes. Fixes job name not being correctly passed to the graph statement from the data model. ### Checklist Provide proof that this works (this makes reviews move faster). Please perform one or more of the following: - [x] Include console log trace showing what happened before and after your changes. Before ``` INFO:cartography.graph.statement:Completed None statement #None INFO:cartography.graph.statement:Completed None statement #None INFO:cartography.graph.job:Finished job EMRCluster ``` ``` INFO:cartography.intel.aws.inspector:Running AWS Inspector cleanup INFO:cartography.graph.statement:Completed None statement #None INFO:cartography.graph.statement:Completed None statement #None INFO:cartography.graph.statement:Completed None statement #None INFO:cartography.graph.statement:Completed None statement #None INFO:cartography.graph.statement:Completed None statement #None INFO:cartography.graph.job:Finished job AWSInspectorFinding INFO:cartography.graph.statement:Completed None statement #None INFO:cartography.graph.statement:Completed None statement #None INFO:cartography.graph.statement:Completed None statement #None INFO:cartography.graph.job:Finished job AWSInspectorPackage ``` After ``` INFO:cartography.graph.statement:Completed EMRCluster statement #1 INFO:cartography.graph.statement:Completed EMRCluster statement cartography-cncf#2 INFO:cartography.graph.job:Finished job EMRCluster ``` ``` INFO:cartography.intel.aws.inspector:Running AWS Inspector cleanup INFO:cartography.graph.statement:Completed AWSInspectorFinding statement #1 INFO:cartography.graph.statement:Completed AWSInspectorFinding statement cartography-cncf#2 INFO:cartography.graph.statement:Completed AWSInspectorFinding statement cartography-cncf#3 INFO:cartography.graph.statement:Completed AWSInspectorFinding statement cartography-cncf#4 INFO:cartography.graph.statement:Completed AWSInspectorFinding statement cartography-cncf#5 INFO:cartography.graph.job:Finished job AWSInspectorFinding INFO:cartography.graph.statement:Completed AWSInspectorPackage statement #1 INFO:cartography.graph.statement:Completed AWSInspectorPackage statement cartography-cncf#2 INFO:cartography.graph.statement:Completed AWSInspectorPackage statement cartography-cncf#3 INFO:cartography.graph.job:Finished job AWSInspectorPackage ``` Signed-off-by: chandanchowdhury <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes job name not being correctly passed to the graph statement from the data model.
Checklist
Provide proof that this works (this makes reviews move faster). Please perform one or more of the following:
Before
After