#1302: Refactor EC2 LaunchTemplate to use data model #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heryxpc
reviewed
Jun 17, 2024
|
|
||
| # Reformat some fields | ||
| current['Id'] = f"{version['LaunchTemplateId']}-{version['VersionNumber']}" | ||
| current['CreateTime'] = str(int(version['CreateTime'].timestamp())) |
There was a problem hiding this comment.
Same as above comment about the expected value of CreateTime.
There was a problem hiding this comment.
Always available.
Side note: neo4j datetime support has improved a lot since this module was first written so we don't even need this str(int()) thing anymore, but for the sake of not breaking any interfaces and keeping the existing behavior I will defer that change to a future PR.
heryxpc
reviewed
Jun 17, 2024
| result: list[dict[str, Any]] = [] | ||
| for template in templates: | ||
| current = template.copy() | ||
| current['CreateTime'] = str(int(current['CreateTime'].timestamp())) |
There was a problem hiding this comment.
Is it safe to consider CreateTime a always present ISO 8601 format date or is it safer to use a .get and return a null value in case it's missing?
heryxpc
approved these changes
Jun 17, 2024
achantavy
added a commit
that referenced
this pull request
Jun 17, 2024
chandanchowdhury
pushed a commit
to juju4/cartography
that referenced
this pull request
Jun 26, 2024
…artography-cncf#1312) Fixes cartography-cncf#1302: refactors EC2 launch template sync to use data model. This way, writes to the graph are automatically batched and write failures are retried.
chandanchowdhury
pushed a commit
to juju4/cartography
that referenced
this pull request
Jun 26, 2024
…cartography-cncf#1314) Forgot to remove some manual index creations in cartography-cncf#1312.
SecPrez
pushed a commit
to SecPrez/cartography
that referenced
this pull request
Nov 10, 2024
…artography-cncf#1312) Fixes cartography-cncf#1302: refactors EC2 launch template sync to use data model. This way, writes to the graph are automatically batched and write failures are retried.
SecPrez
pushed a commit
to SecPrez/cartography
that referenced
this pull request
Nov 10, 2024
…cartography-cncf#1314) Forgot to remove some manual index creations in cartography-cncf#1312.
chandanchowdhury
pushed a commit
to chandanchowdhury/cartography
that referenced
this pull request
Nov 27, 2024
…artography-cncf#1312) Fixes cartography-cncf#1302: refactors EC2 launch template sync to use data model. This way, writes to the graph are automatically batched and write failures are retried. Signed-off-by: chandanchowdhury <[email protected]>
chandanchowdhury
pushed a commit
to chandanchowdhury/cartography
that referenced
this pull request
Nov 27, 2024
…cartography-cncf#1314) Forgot to remove some manual index creations in cartography-cncf#1312. Signed-off-by: chandanchowdhury <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1302: refactors EC2 launch template sync to use data model. This way, writes to the graph are automatically batched and write failures are retried.