fix :#1218, #1152 - refactor EC2 network interface, private ip #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achantavy
changed the title
achantavy
changed the title
achantavy
force-pushed
the
refactornetworkinterfaces
branch
from
bac1e91 to
5875244
Compare
This was referenced Jul 17, 2023
ramonpetgrave64
requested changes
Aug 29, 2023
achantavy
force-pushed
the
refactornetworkinterfaces
branch
from
4accca8 to
1426cff
Compare
ramonpetgrave64
previously approved these changes
Sep 12, 2023
Comment on lines
+84
to
+85
| if network_interface.get('PrivateIpAddresses'): | ||
| for private_ip_address in network_interface['PrivateIpAddresses']: |
There was a problem hiding this comment.
Non blocker: chane this to
Suggested change
| if network_interface.get('PrivateIpAddresses'): | |
| for private_ip_address in network_interface['PrivateIpAddresses']: | |
| for private_ip_address in network_interface.get('PrivateIpAddresses', []): |
Comment on lines
33
to
38
| interface_type: PropertyRef = PropertyRef('InterfaceType') | ||
| public_ip: PropertyRef = PropertyRef('PublicIp') | ||
| requester_id: PropertyRef = PropertyRef('RequesterId') | ||
| requester_managed: PropertyRef = PropertyRef('RequesterManaged') | ||
| source_dest_check: PropertyRef = PropertyRef('SourceDestCheck') | ||
| subnetid: PropertyRef = PropertyRef('SubnetId') |
There was a problem hiding this comment.
extra indexes for public_ip, subnet_id, and maybe requester_id
ramonpetgrave64
approved these changes
Sep 20, 2023
chandanchowdhury
pushed a commit
to juju4/cartography
that referenced
this pull request
Jun 26, 2024
…ork interface, private ip (cartography-cncf#1219) Refactors EC2 Network Interfaces and Private IPs to the cartography data model. Fixes cartography-cncf#1152 since the data model includes automatic cleanup jobs. - Uses same technique as cartography-cncf#1214 to represent Network Interfaces as known by EC2 instances vs Network Interfaces known by describe-network-interfaces. - Also clearly marks that the Private IPs ingested here are known by Network Interfaces and not another source.
achantavy
commented
Nov 8, 2024
| mac_address: PropertyRef = PropertyRef('MacAddress', extra_index=True) | ||
| description: PropertyRef = PropertyRef('Description') | ||
| private_dns_name: PropertyRef = PropertyRef('PrivateDnsName', extra_index=True) | ||
| private_ip_address: PropertyRef = PropertyRef('PrivateIpAddress', extra_index=True) |
There was a problem hiding this comment.
@serge-wq - [comment 1 of 2] here's an example of what we were talking about earlier: a network interface as known by an EC2 instance has a private_ip_address...
There was a problem hiding this comment.
actually never mind, wait let me find a better example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors EC2 Network Interfaces and Private IPs to the cartography data model. Fixes #1152 since the data model includes automatic cleanup jobs.