Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typo in Azure load_vms cypher #1047

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

amirjalali65
Copy link
Contributor

No description provided.

@achantavy
Copy link
Contributor

Thanks for the fix! Can you please sign the CLA?

@achantavy achantavy changed the title fixed typo in load_vms cypher fixed typo in Azure load_vms cypher Dec 14, 2022
@amirjalali65
Copy link
Contributor Author

amirjalali65 commented Dec 14, 2022

I've already signed the CLA. Seems the check needs to be retriggered.

signed_CLA

@ramonpetgrave64
Copy link
Collaborator

@amirjalali65 It looks like the commit you authored doesn't have your actual github name associated with the commit. You'll need to setup your git config
https://docs.github.com/en/pull-requests/committing-changes-to-your-project/troubleshooting-commits/why-are-my-commits-linked-to-the-wrong-user

@ramonpetgrave64
Copy link
Collaborator

@amirjalali65 Some of the commits still have the wrong author, so you'll need to rebase/squash and maybe do a force-push.
https://github.com/lyft/cartography/pull/1047/commits

@ramonpetgrave64 ramonpetgrave64 enabled auto-merge (squash) January 5, 2023 14:24
@achantavy
Copy link
Contributor

@amirjalali65 Wow, how did we miss this one for so long haha, sorry for the delay and thank you for the contribution!

@chandanchowdhury - thank you for spotting this!

@achantavy achantavy merged commit f14755e into cartography-cncf:master Jun 26, 2024
5 checks passed
chandanchowdhury pushed a commit to juju4/cartography that referenced this pull request Jun 26, 2024
SecPrez pushed a commit to SecPrez/cartography that referenced this pull request Nov 10, 2024
chandanchowdhury pushed a commit to chandanchowdhury/cartography that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants