Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object_id results in unstable uploader class names #2407

Closed
deecewan opened this issue Jul 23, 2019 · 0 comments
Closed

object_id results in unstable uploader class names #2407

deecewan opened this issue Jul 23, 2019 · 0 comments

Comments

@deecewan
Copy link

deecewan commented Jul 23, 2019

Hey 👋

We're testing out sorbet in our project, and CarrierWave is causing a couple of issues with the types that are generated. I've narrowed it down to this line:

const_set("Uploader#{uploader.object_id}".tr('-', '_'), uploader)

Is there nothing more stable than object_id that could be used? Something that is stable across runs?

I've tried looking through the commit history and got to about 7 years ago. I'm not familiar with the internals of the project at all, but what is the benefit in using the object_id at all?

Edit: found this issue #793. It seems to be why the Uploader is named dynamically. I'm very for having some kind of dynamic name - that doesn't phase me. It'd just be great if it was stable across runs.

@mshibuya mshibuya added this to the Release v3.0.0 milestone Jan 14, 2023
mshibuya added a commit that referenced this issue Jan 15, 2023
mshibuya added a commit that referenced this issue Jan 15, 2023
mshibuya added a commit that referenced this issue Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants