Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove multi_json #1105

Closed
steveklabnik opened this issue May 29, 2013 · 5 comments
Closed

Remove multi_json #1105

steveklabnik opened this issue May 29, 2013 · 5 comments

Comments

@steveklabnik
Copy link
Contributor

Soon, multi_json is no longer being maintained, so carrierwave shouldn't use it any more.

If there's interest in this, I might be willing to work up a patch.
@bensie
Copy link
Member

bensie commented May 29, 2013

Added just 3 short months ago: #968

What's the best approach now? Just using JSON? Reverting to ActiveSupport::JSON?

@steveklabnik
Copy link
Contributor Author

For my own gems, I just use the stdlib JSON.

@bensie
Copy link
Member

bensie commented May 29, 2013

Cool with me -- feel free to open another PR or I'll knock this out the next time I'm triaging CarrierWave :)

@steveklabnik
Copy link
Contributor Author

Word. I'm not 100% sure when I'll have the time, but whoever gets to it first works. :)

srbiv pushed a commit to srbiv/carrierwave that referenced this issue May 30, 2013
Replace multi_json with JSON
0b09d0d 
carrierwaveuploader#1105
@srbiv srbiv mentioned this issue May 30, 2013
Closed
@bensie bensie closed this as completed in 3d9f2cb May 30, 2013
@steveklabnik
Copy link
Contributor Author

❤️ :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bensie @steveklabnik