Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update timing format for syllabus #363

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Conversation

zkamvar
Copy link
Contributor

@zkamvar zkamvar commented Nov 8, 2022

This updates the timestamp in the syllabus to read XXh YYm intead of XX:YY
to clearly indicate the units of time.

This will fix #361, which will address carpentries/conversations#40

To preview this change, you can use the {remotes} package:

# install.packages("remotes")
remotes::install_github("carpentries/sandpaper#363")

When you are done, you can re-install the current version of sandpaper like so:

install.packages("sandpaper", repos = "https://carpentries.r-universe.dev")

@zkamvar zkamvar requested a review from tobyhodges November 8, 2022 16:52
@tobyhodges
Copy link
Member

I like the change to show timing in hours and minutes. However, in reviewing the PR I noticed that the landing page now has the title "Summary and Schedule" in both the Learner and Instructor View. The schedule table only appears in the instructor view, though.

As I guess this is a separate issue, not something introduced in this PR, I am happy to approve.

Screenshot 2022-11-09 at 10 46 15

Screenshot 2022-11-09 at 10 50 35

@zkamvar zkamvar merged commit d94acec into main Nov 9, 2022
@zkamvar zkamvar deleted the update-timestamp-fix-361 branch November 9, 2022 14:49
@zkamvar
Copy link
Contributor Author

zkamvar commented Nov 9, 2022

Thank you for the catch, Toby! I've opened a new issue for the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use XXhXX instead of XX:XX for schedule tables
2 participants