Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mangle member name in deletion generator #1458

Merged
merged 1 commit into from
Feb 28, 2023
Merged

fix: mangle member name in deletion generator #1458

merged 1 commit into from
Feb 28, 2023

Conversation

hellerve
Copy link
Member

Before, the member deletion did not mangle the member name, so members named things like default (as is the case in https://github.com/carpentry-org/clig) would emit faulty C.

Cheers

@hellerve hellerve requested a review from a team February 26, 2023 18:49
@hellerve hellerve added the bug label Feb 26, 2023
@scolsen
Copy link
Contributor

scolsen commented Feb 27, 2023

Nice catch!

@eriksvedang eriksvedang merged commit ed2a410 into carp-lang:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scolsen scolsen scolsen approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hellerve @scolsen @eriksvedang