fix: use non-deprecated unlink function on windows

[hellerve]

This PR fixes our unlink varieties on Windows by using the non-deprecated _unlink function instead of unlink.

Cheers

[hellerve]

This fixes the problem, but there is a followup issue with the address sanitizer on Windows. I don’t think I’ll be able to debug this; I don’t currently have access to a Windows machine.

[TimDeve]

The ASAN error is definitely an odd one, I've found a few similar errors online but nothing concrete, I'm wondering if this is related to that specific build/packaging of llvm. I'll try a Windows build on my local machine.

[eriksvedang]

The ASAN error is definitely an odd one, I've found a few similar errors online but nothing concrete, I'm wondering if this is related to that specific build/packaging of llvm. I'll try a Windows build on my local machine.

Yes, please – this is really strange. I'll hold off mergeing until we know a bit more.

[TimDeve]

It is kinda weird that we're seeing some changes here given that we're using the same llvm version in the last passing Windows build and this one. Maybe a change in the underlying Windows image if the problems come from the system headers?

[TimDeve]

I think it's still fine to merge this as the deprecation and the Address Sanitizer issues seem separate. See #1314.

[eriksvedang]

Very nice!