Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(and) and (or) now handle any number of parameters #1251

Merged
merged 4 commits into from
Jun 20, 2021

Conversation

guberathome
Copy link
Contributor

So far the macros and and or expected exactly 2 parameters.
The new version - inspired by Scheme - can handle anything from 0 upwards.

@guberathome guberathome marked this pull request as draft June 16, 2021 17:27
@guberathome
Copy link
Contributor Author

So the functionality is there, the macro expansions look good,
but the Carp needs suspicously much memory to compile the unit tests.

If you want to have a look, commit 0655724
has the details.

@scolsen
Copy link
Contributor

scolsen commented Jun 16, 2021

So the functionality is there, the macro expansions look good,
but the Carp needs suspicously much memory to compile the unit tests.

If you want to have a look, commit 0655724
has the details.

Interesting! Good find. The macro tests in general take a huge amount of time to compile and run (it's by far the longest portion of running all the unit tests for compiler changes), so you're probably getting us closer here to figuring out the potential hotspot in the compiler that's causing this.

@guberathome guberathome marked this pull request as ready for review June 16, 2021 20:13
@guberathome
Copy link
Contributor Author

Unit tests should be fine now (thanks @hellerve)
I'll open a new request for the compiler issue.

@eriksvedang eriksvedang merged commit 0d15a57 into carp-lang:master Jun 20, 2021
@eriksvedang
Copy link
Collaborator

Excellent!

@guberathome guberathome deleted the and-or-general branch June 20, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants