Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gotify X-Gotify-Key Header vs params token #558

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

caronc
Copy link
Owner

@caronc caronc commented Mar 27, 2022

Description:

Related issue (if applicable): #556

With respect to documentation here and the related issue above, this request updates Apprise's integration with Gotify to use the HTTP Headers to pass the token along instead of the querystring

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in
# This way you can just destroy it after when it's all over.
# The below will create a directory called apprise
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@556-gotify-header-token

# Run your Gotify Tests
apprise gotify://credentials

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2022

Codecov Report

Merging #558 (33cbbc4) into master (4cc5be0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #558   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          106       106           
  Lines        13696     13695    -1     
  Branches      2544      2544           
=========================================
- Hits         13696     13695    -1     
Impacted Files Coverage Δ
apprise/plugins/NotifyGotify.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc5be0...33cbbc4. Read the comment docs.

@caronc caronc merged commit fc60dcd into master Mar 28, 2022
@caronc caronc deleted the 556-gotify-header-token branch March 29, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants