Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML to TEXT/MARKDOWN cleanup and refactoring #530

Merged
merged 4 commits into from
Feb 2, 2022

Conversation

caronc
Copy link
Owner

@caronc caronc commented Jan 29, 2022

Description:

Related issue (if applicable): #527

@YoRyan , maybe you could have a look at this branch and check out the last test i wrote that isn't passing.

I had to re-factor your work a little to cover more cases; but you still had a fantastic start.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

@YoRyan
Copy link
Contributor

YoRyan commented Jan 31, 2022

If we restrict ourselves to the primitive parser in the standard library, some limitations are inevitable—web browsers specialize in parsing this kind of badly formatted HTML, after all. Nevertheless, after giving the code my own rework, I have gotten it to pass all of your tests. 🙂

fix-html-converter.patch

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2022

Codecov Report

Merging #530 (5bb6e5c) into master (8fa1466) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #530   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          106       106           
  Lines        13565     13597   +32     
  Branches      2501      2511   +10     
=========================================
+ Hits         13565     13597   +32     
Impacted Files Coverage Δ
apprise/Apprise.py 100.00% <100.00%> (ø)
apprise/conversion.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fa1466...5bb6e5c. Read the comment docs.

@caronc caronc force-pushed the 527-html-text-additional-testing branch from 36de304 to 5bb6e5c Compare February 2, 2022 03:17
@caronc
Copy link
Owner Author

caronc commented Feb 2, 2022

@YoRyan ; I think we nailed it between both of our changes. I couldn't have done it without you! I'll merge this and work on an official release next. 🚀

@caronc caronc merged commit 405e26e into master Feb 2, 2022
@caronc caronc deleted the 527-html-text-additional-testing branch March 5, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants