Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/opt/homebrew/bin/terminal-notify added to MacOSX #509

Merged
merged 2 commits into from
Dec 28, 2021

Conversation

caronc
Copy link
Owner

@caronc caronc commented Dec 28, 2021

Description:

Related issue (if applicable): #508

MacOSX plugin now supports the handling of multiple notifier paths (it will use whatever matches first). Additionally added /opt/homebrew/bin/terminal-notify to the head of this list.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2021

Codecov Report

Merging #509 (c5b9a5e) into master (c06a2f3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #509    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           99       100     +1     
  Lines        13060     13402   +342     
  Branches      2386      2492   +106     
==========================================
+ Hits         13060     13402   +342     
Impacted Files Coverage Δ
apprise/plugins/NotifyMacOSX.py 100.00% <100.00%> (ø)
apprise/utils.py 100.00% <0.00%> (ø)
apprise/plugins/NotifyDapnet.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c06a2f3...c5b9a5e. Read the comment docs.

@caronc caronc merged commit 12326c7 into master Dec 28, 2021
@caronc caronc deleted the 508-macos-homebrew-path branch March 5, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants