-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for streamlabs #427
Conversation
any recommendations to get the test coverage up? Should I also create a |
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 95 96 +1
Lines 12083 12248 +165
Branches 2034 2060 +26
==========================================
+ Hits 12083 12248 +165
Continue to review full report at Codecov.
|
This is amazing; thank you very much for the PR! 🚀 ❤️ 🙂
You should be able to probably cover all of your code using the You can create an extra test file too if you want; but I usually only resort to them to test weird edge cases. Chris |
@t-900-a I'm really impressed with this merge request, you've really done a great job. There are just a few small tweaks and I'll hit the merge:
btw: sorry to be such a pain; I'm a bit of a perfectionist, but your work is just fantastic - we're almost there Edit: Just added the underscore point; please feel free to debate anything too if you disagree. |
ok, will do
ok, will do
ok, will do
Documentation will be similar to this document, except we manually have to modify a url to retrieve the token. Do you do the documentation all yourself, or do you want contributors? I'm not eager to write docs, but I can try to find someone to help. For consistency to the existing code base I'm happy to make the changes. Expect some delay however. |
@t-900-a Great! thank you so much!
This URL doesn't appear to work for me.
I don't mind putting together the wiki page. 🙂 I just need an 'explain it like I'm 5' example (or a link to another web page as your attempting to share too is fine) that lets me (and others) know how they can get an API token.
No rush at all; I really appreciate your efforts and great work! Thanks again ❤️ 👍 |
Working link: https://github.com/Fittiboy/lnbits/tree/master/lnbits/extensions/streamalerts#stream-alerts Instructions will be a variation of the above. |
I started this wiki page sourcing the website you provided and attempted to give full credit to the images used. However i'm confused how your version of it with Apprise works since the example uses a client/secret combination, not an `api_token? |
There's one additional step to get the api token. I can add it to the wiki. |
@t-900-a: I'm going to do another version. I'd like to pack all of your efforts into it. So i'm going to merge your code. But it would be most appreciative if you could share the step(s) i'm missing to get the API key (in order to make everything you shared work). |
Added a couple steps for the user to generate their access token. It is involved, but it's a one time deal. Thanks for merging! |
Description:
Related issue (if applicable): #243
New Service Completion Status
keywords
section of thesetup()
declaration%global common_description
Checklist
flake8
)