Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed HTML escaping for Telegram TEXT handling #383

Merged
merged 1 commit into from
May 2, 2021

Conversation

caronc
Copy link
Owner

@caronc caronc commented May 2, 2021

Description:

Related issue (if applicable): #373
Escaping the HTML characters before passing the content along to Telegram causes the upstream service to re-escape them again.

This small merge request just drops the escaping of these characters since it is no longer required.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2021

Codecov Report

Merging #383 (98f3886) into master (975b172) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #383   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           93        93           
  Lines        11767     11765    -2     
  Branches      1960      1960           
=========================================
- Hits         11767     11765    -2     
Impacted Files Coverage Δ
apprise/plugins/NotifyTelegram.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 975b172...98f3886. Read the comment docs.

@caronc caronc merged commit 3938cd9 into master May 2, 2021
@caronc caronc deleted the 373-telegram-escaped-characters branch May 2, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants