Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed MSTeams webhook handling for new format #380

Merged
merged 2 commits into from
May 2, 2021
Merged

Conversation

caronc
Copy link
Owner

@caronc caronc commented Apr 29, 2021

Description:

Related issue (if applicable): #378

Addresses a bug originally created in #361 where it was attempted to support the new MSTeams webhook format. It appears I got it wrong 🤦‍♂️ .

This PR will hopefully resolve the issue, but would love help testing it out. To do so:

# Create a virtual environment to work in
# This way you can just destroy it after when it's all over.
# The below will create a directory called apprise
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch with new MSTeams Support
pip install git+https://github.com/caronc/apprise.git@378-msteams-url-update

# Give it a go:
# The syntax is like so:
apprise -t "Title" -b "Body" "msteams://{team}/tokenA/tokenB/tokenC"

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2021

Codecov Report

Merging #380 (3c65b7f) into master (0b60e99) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #380   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           93        93           
  Lines        11747     11767   +20     
  Branches      1954      1960    +6     
=========================================
+ Hits         11747     11767   +20     
Impacted Files Coverage Δ
apprise/plugins/NotifyMSTeams.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b60e99...3c65b7f. Read the comment docs.

@caronc caronc force-pushed the 378-msteams-url-update branch 2 times, most recently from 30fca1b to a4aa56f Compare April 30, 2021 20:38
@caronc caronc merged commit 975b172 into master May 2, 2021
@caronc caronc deleted the 378-msteams-url-update branch May 2, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants