Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SparkPost cc and bcc improvements #309

Merged
merged 1 commit into from
Oct 6, 2020
Merged

SparkPost cc and bcc improvements #309

merged 1 commit into from
Oct 6, 2020

Conversation

caronc
Copy link
Owner

@caronc caronc commented Oct 6, 2020

Description:

Related issue (if applicable): #307

Just some added testing and overlooked the correct handling of cc/bcc emails.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2020

Codecov Report

Merging #309 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #309   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           84        84           
  Lines        10483     10483           
  Branches      1750      1749    -1     
=========================================
  Hits         10483     10483           
Impacted Files Coverage Δ
apprise/plugins/NotifySparkPost.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89eaffa...6d7c7a7. Read the comment docs.

@caronc caronc merged commit b8105c3 into master Oct 6, 2020
@caronc caronc deleted the sparkpost-updates branch October 11, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants