Python asyncio Integration - Notifications sent Asynchronously #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caronc
force-pushed
the
python3-async-support
branch
9 times, most recently
from
e815f5f
to
a6a0192
Compare
caronc
force-pushed
the
python3-async-support
branch
from
a6a0192
to
56e0c6e
Compare
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 82 83 +1
Lines 9703 9756 +53
Branches 1551 1562 +11
=========================================
+ Hits 9703 9756 +53
Continue to review full report at Codecov.
|
caronc
changed the title
caronc
changed the title
This was referenced Oct 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Apprise sends each notification one after another (sequentially). Leveraging the
async/awaitwith theasynciolibrary would allow one to send all of the pending notifications at the same time.This feature identified in this PR only works with Python 3 platforms. Python v2 users will always send via the synchronous method (as they have in the past).
--disable-async(-Da) which allows Python 3 instances of Apprise to behave the way it once did (before this pull request) and sequentially send the notifications.--debug(-D) switch to the CLI as well which not only defaults the logging verbosity to DEBUG level, it additionally sets theasynciomodule in debug mode under the hood.async_modetoFalse(it defaults toTrue) in the AppriseAsset() object if you want to go back to the legacy way of sending notifications.Other things to note from this PR:
async_modeis at a notification service level. So developers can set some notifications to run asynchronously and others to run synchronously if they wish. This is determined by the AppriseAsset loaded per notification plugin.Checklist
flake8)