Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bark - add critical level alert plus ?volume= argument #1239

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pb8DvwQkfRR
Copy link

@pb8DvwQkfRR pb8DvwQkfRR commented Nov 16, 2024

Description:

Critical Alert will ignore silent and Do Not Disturb modes.
Volume range: 0-10.

Finb/Bark@f059fde

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/pb8DvwQkfRR/apprise.git@bark-critical

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  bark://api.day.app/<device_key>/?level=critical&volume=1

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 99.35%. Comparing base (f37dfbf) to head (c33984c).

Files with missing lines Patch % Lines
apprise/plugins/bark.py 80.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1239      +/-   ##
==========================================
- Coverage   99.36%   99.35%   -0.02%     
==========================================
  Files         147      147              
  Lines       20555    20570      +15     
  Branches     3663     3668       +5     
==========================================
+ Hits        20425    20437      +12     
- Misses        121      122       +1     
- Partials        9       11       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc changed the title Bark add critical level alart Bark - add critical level alert plus ?volume= argument Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant