Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin paho-mqtt version #1238

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Unpin paho-mqtt version #1238

merged 1 commit into from
Nov 15, 2024

Conversation

kruton
Copy link
Contributor

@kruton kruton commented Nov 15, 2024

The new update to paho-mqtt, version 2.1.0, fixed the backward incompatible callback signature problem by defaulting the callback type to paho-mqtt V1 style callbacks. This means that packages can upgrade to paho-mqtt 2.1.0 or leave it at <2.0.0 without any software changes.

Description:

Related issue (if applicable): #1065 (original issue where they pinned)

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Modify dockerfile to include paho-mqtt
perl -pi -e 's,^(RUN pip.*requirements.txt$),COPY all-plugin-requirements.txt /\n\1 -r /all-plugin-requirements.txt,g' test/docker/Dockerfile.py311

# Build the container
docker compose build test.py311

# Run MQTT tests
docker compose run --rm test.py311 bin/test.sh mqtt

The new update to paho-mqtt, version 2.1.0, fixed the backward incompatible callback
signature problem by defaulting the callback type to paho-mqtt V1 style callbacks.
This means that packages can upgrade to paho-mqtt 2.1.0 or leave it at <2.0.0 without
any software changes.

This was originally pinned with #1065.
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.36%. Comparing base (01c1082) to head (52dc316).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1238   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files         147      147           
  Lines       20555    20555           
  Branches     3663     3663           
=======================================
  Hits        20425    20425           
  Misses        121      121           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc
Copy link
Owner

caronc commented Nov 15, 2024

Thank you! 🙏

@caronc caronc merged commit f37dfbf into caronc:master Nov 15, 2024
13 checks passed
kruton added a commit to kruton/changedetection.io that referenced this pull request Nov 15, 2024
The paho-mqtt backwards compatibility problem was fixed with version
2.1.0, so we only need to avoid the 2.0.x series of releases. Upstream
apprise is currently being tested with paho-mqtt 2.1.0 as part of my
fix at caronc/apprise#1238

This narrows the workaround for issue dgtlmoon#2241
kruton added a commit to kruton/changedetection.io that referenced this pull request Nov 15, 2024
The paho-mqtt backwards compatibility problem was fixed with version
2.1.0, so we only need to avoid the 2.0.x series of releases. Upstream
apprise is currently being tested with paho-mqtt 2.1.0 as part of my
fix at caronc/apprise#1238

This narrows the workaround for issue dgtlmoon#2241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants