Fixes random matrix:// unittest failures #1166
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): #1162
matrix://
unit tests fail randomly. Heavy kudos to @fabiottini for finding that it's random calls tologout()
.Since the
NotifyMatrix()
Plugin attempts to automatically close any established connections when the object is removed from memory, the randomness kind of hints that it's the garbage collection that is kicking in and freeing up an unhandled object later on.This PR ensures that the
matrix://
object is safely removed from memory after each unit test which SHOULD prevent the randomness from occuring in the future.Checklist
flake8
)Testing
Anyone can help test this source code as follows: