Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom module deadlock import fix #1077

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Conversation

caronc
Copy link
Owner

@caronc caronc commented Mar 7, 2024

Description:

Related issue (if applicable): #1075

Deadlock issue resolved that was created in #1071

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@1075-custom-module-deadlock-fix

cat << _EOF > test.py
from apprise.decorators import notify

@notify(on="test")
def my_wrapper(body, title, *args, **kwargs):
  print(f"{title}: {body}")
_EOF

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  -P ./test.py  test://

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.27%. Comparing base (b4798e3) to head (251fa4c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1077      +/-   ##
==========================================
- Coverage   99.27%   99.27%   -0.01%     
==========================================
  Files         136      136              
  Lines       17753    17752       -1     
  Branches     3623     3622       -1     
==========================================
- Hits        17625    17624       -1     
  Misses        119      119              
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit d5cbab1 into master Mar 8, 2024
12 checks passed
@caronc caronc deleted the 1075-custom-module-deadlock-fix branch April 6, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants