Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revolt Plugin Refactored #1062

Merged
merged 2 commits into from
Feb 18, 2024
Merged

Revolt Plugin Refactored #1062

merged 2 commits into from
Feb 18, 2024

Conversation

caronc
Copy link
Owner

@caronc caronc commented Feb 18, 2024

Description:

Related issue (if applicable): #1057

Refactored the Revolt plugin to allow markdown to work. Refactoring also allows multiple channels to be specified on the Apprise URL:

  • revolt://bot_token/channel
  • revolt://bot_token/channel1/channel2/channelN

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@1057-revolt-tidy

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  "revolt://credentials

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6764590) 99.26% compared to head (6523e20) 99.27%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1062      +/-   ##
==========================================
+ Coverage   99.26%   99.27%   +0.01%     
==========================================
  Files         136      136              
  Lines       17733    17738       +5     
  Branches     3616     3618       +2     
==========================================
+ Hits        17602    17610       +8     
+ Misses        120      119       -1     
+ Partials       11        9       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit 119b4f0 into master Feb 18, 2024
12 checks passed
@caronc caronc deleted the 1057-revolt-tidy branch February 21, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants