Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved ConfigMemory AttributeError Exception #1032

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

caronc
Copy link
Owner

@caronc caronc commented Dec 28, 2023

Description:

Related issue (if applicable): n/a

When trying to adapt Apprise v1.7.0 with the Apprise API, the following exception was thrown (relating back to this package):

2023-12-28 12:54:05,342 [ERROR] django.request: Internal Server Error: /json/urls/apprise/
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/views/generic/base.py", line 104, in view
    return self.dispatch(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/utils/decorators.py", line 46, in _wrapper
    return bound_method(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/utils/decorators.py", line 134, in _wrapper_view
    response = view_func(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/views/decorators/cache.py", line 62, in _wrapper_view_func
    response = view_func(request, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/django/views/generic/base.py", line 143, in dispatch
    return handler(request, *args, **kwargs)
  File "/apprise-api/apprise_api/api/views.py", line 1199, in get
    ac_obj.add_config(config, format=format)
  File "/apprise-api/.local/lib/python3.10/site-packages/apprise/AppriseConfig.py", line 258, in add_config
    instance = config.ConfigMemory.ConfigMemory(
AttributeError: module 'apprise.config' has no attribute 'ConfigMemory'

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@attribute-error-configmemory

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c47de7f) 99.27% compared to head (b9cd303) 99.27%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1032      +/-   ##
==========================================
- Coverage   99.27%   99.27%   -0.01%     
==========================================
  Files         136      136              
  Lines       17669    17668       -1     
  Branches     3603     3603              
==========================================
- Hits        17541    17540       -1     
  Misses        119      119              
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit c8d9750 into master Dec 28, 2023
12 checks passed
@caronc caronc deleted the attribute-error-configmemory branch December 29, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants