-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.12 Support #1031
Python 3.12 Support #1031
Conversation
OK, number 1 with highlight, having uninstalled Python "everywhere" and done a reboot / reinstall I am running fine with Apprise 1.7.0 and Python 3.12.1... But... I am getting:
Complete trace below:
|
Try this instead (make sure you're in the cloned repo): docker-compose run --rm test.py312 bash
# now you'll gain access to a terminal inside your image... now do:
bin/checkdone.sh |
Sorry, no joy... (apprise) Matt-Packwoods-iMac:apprise $ docker-compose run --rm test.py312 bash
no configuration file provided: not found I have searched through what pip pulled down and cannot find anything called I am executing the docker command while sitting at When I type (apprise) Matt-Packwoods-iMac:apprise $ ls
bin include lib pyvenv.cfg I ran a find looking for the test, here is what came up: (apprise) Matt-Packwoods-iMac:apprise $ find . -name "*test*"
./lib/python3.11/site-packages/markdown/__pycache__/test_tools.cpython-311.pyc
./lib/python3.11/site-packages/markdown/test_tools.py
./lib/python3.11/site-packages/click/__pycache__/testing.cpython-311.pyc
./lib/python3.11/site-packages/click/testing.py
./lib/python3.11/site-packages/pip/_vendor/webencodings/__pycache__/tests.cpython-311.pyc
./lib/python3.11/site-packages/pip/_vendor/webencodings/tests.py
./lib/python3.11/site-packages/pip/_vendor/pyparsing/__pycache__/testing.cpython-311.pyc
./lib/python3.11/site-packages/pip/_vendor/pyparsing/testing.py
./lib/python3.11/site-packages/pip/_vendor/colorama/tests
./lib/python3.11/site-packages/pip/_vendor/colorama/tests/isatty_test.py
./lib/python3.11/site-packages/pip/_vendor/colorama/tests/initialise_test.py
./lib/python3.11/site-packages/pip/_vendor/colorama/tests/__pycache__/winterm_test.cpython-311.pyc
./lib/python3.11/site-packages/pip/_vendor/colorama/tests/__pycache__/initialise_test.cpython-311.pyc
./lib/python3.11/site-packages/pip/_vendor/colorama/tests/__pycache__/isatty_test.cpython-311.pyc
./lib/python3.11/site-packages/pip/_vendor/colorama/tests/__pycache__/ansi_test.cpython-311.pyc
./lib/python3.11/site-packages/pip/_vendor/colorama/tests/__pycache__/ansitowin32_test.cpython-311.pyc
./lib/python3.11/site-packages/pip/_vendor/colorama/tests/ansi_test.py
./lib/python3.11/site-packages/pip/_vendor/colorama/tests/winterm_test.py
./lib/python3.11/site-packages/pip/_vendor/colorama/tests/ansitowin32_test.py
./lib/python3.11/site-packages/setuptools/command/__pycache__/test.cpython-311.pyc
./lib/python3.11/site-packages/setuptools/command/test.py
(apprise) Matt-Packwoods-iMac:apprise $ |
So the problem is that you're not following the test instructions i provided. It's almost as though your just running the last 2 actions. Perhaps you're still using brew? If you check out the branch, and change into it. The configuration (missing for you based on your shared output); would exist and the last 2 commands would work 😉. Either way, i can confirm Python 3.12 works fine. I'm going to close off this issue. 🚀 |
No issues that it is running but... There was a step I think you assumed in your instructions that I needed to figure out, see below. # Create a virtual environment to work in as follows:
python3 -m venv apprise
# Change into our new directory
cd apprise
# Activate our virtual environment
source bin/activate
# Install the branch
pip install git+https://github.com/caronc/apprise.git@1030-python-3-12-support THEN clone the branch, cd into the downloaded branch <- I assumed the pip was pulling everything I needed, MY mistake. # Run entire test suite:
docker-compose run --rm test.py312 bin/checkdone.sh I am NOT trying to be a pain and profound apologies if I am coming across that way, I am trying to figure this stuff out. Results were: FAILED test/test_apprise_translations.py::test_apprise_trans_add - AssertionError: assert False is True
============ 1 failed, 400 passed, 50 skipped, 4 warnings in 50.80s ============
Tests failed.``` |
@mattpackwood I'm so sorry, you're absolutely correct that the test didn't have the
You're absolutely not at all. I'm sorry for being short. I absolutely appreciate everything you do! you seem to disappear for a year.. or two, and then just surface with 5-6 issues! 🚀 👍 🙂 I will investigate the error you got. I'm not sure what happened there (it didn't do it to me in my environment) |
No worries, yep, sorry I do seem to do that don't I! I have some other things that keep me distracted I am afraid, I spend my time working in the space between Engineering and Project Management so some years I am up to my ears in Budgets and Forecasts and the next I am working in Digital Twins and Robotics so it depends on where the "needle it that particular year". |
Description:
Related issue (if applicable): #1030
This was created in lieu of the ticket opened that Apprise no longer worked under Python v3.12.
I added in the logic to test it here and everything appears okay.
Checklist
flake8
)Testing