-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort order in country_select #7
Comments
I backported my code to carmen 0.2.13, and now the sorting is fine. |
You're right, this is an issue. I think the way to go with this is to define |
Removing the unpack('U') puts the countries in the correct sort order. A bit confused here about what unpack('U') does .. |
Fixed in master. |
jesusdp
pushed a commit
to designerpages/carmen-rails
that referenced
this issue
May 27, 2020
Fix configuration for Travis CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ruby 1.9.3p194
rails 3.2.3
carmen-rails 1.0.0.beta3
I am a little confused about the sort order of the countries generated by
country_select
. The sorting algorithm from https://github.com/jim/carmen-rails/blob/ada9fc20b65123629fb0831b5997f81f9bfb2a5e/lib/carmen/rails/action_view/form_helper.rb#L88 behaves like this on the command line:As you can see, the order isn't correct because all countries with "G" have the same sort key "[71]".
The text was updated successfully, but these errors were encountered: