Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config to allow subdomain cookies #36

Merged
merged 2 commits into from
May 14, 2014
Merged

Add config to allow subdomain cookies #36

merged 2 commits into from
May 14, 2014

Conversation

Rendez
Copy link
Contributor

@Rendez Rendez commented May 13, 2014

No description provided.

@jescalan
Copy link
Contributor

Hey @Rendez, could you add a description to your PR to explain what you did here and why?

@carlsednaoui
Copy link
Owner

@Rendez the build is failing, likely due to the typo identified by @Jenius: https://travis-ci.org/carlsednaoui/ouibounce/builds/25087625

Also, could you edit the README to document what you're adding?

@Rendez
Copy link
Contributor Author

Rendez commented May 13, 2014

Yeah, will do. Thank you both.

@carlsednaoui carlsednaoui merged commit eacb381 into carlsednaoui:master May 14, 2014
@carlsednaoui
Copy link
Owner

Thanks @Rendez! Loved the detailed README addition :)

Quick note, I committed af49387 — I believe ';domain=' was missing.

Let me know if you find any errors.

Thanks!

@Rendez
Copy link
Contributor Author

Rendez commented May 14, 2014

@carlsednaoui thanks for the fix you're right. Busy day and short attention span :)

@carlsednaoui
Copy link
Owner

👍 :)

@Rendez Rendez deleted the feature-cookie-domain branch November 6, 2014 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rendez @jescalan @carlsednaoui