Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Location Bar Hotkey #21

Closed
wants to merge 6 commits into from

Conversation

schonfeld
Copy link
Contributor

This will add support for detecting when the user focuses on the location bar using the browser's hotkey (Meta + L).

p.s. I couldn't get gulp to build the file... Keep getting some weird gulp error "Assertion failed: (handle->InternalFieldCount() > 0), function Unwrap, file ../src/node_object_wrap.h, line 61."...

@jescalan
Copy link
Contributor

Looook who it is! 🐕

@jescalan
Copy link
Contributor

Just to check on the gulp thing, did you install gulp globally with npm i gulp -g, and still getting that error? If you did this a while ago it also might be an older version...

@carlsednaoui
Copy link
Owner

Thanks @schonfeld! This was rebased and merged.

/reference 1f8896e, c3ddb78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants