Avoid distutils deprecation warning + a few other small fixes #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using distutils.StrictVersion now results in ugly warnings: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead. Use the suggested replacement if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for the library it is very useful 😃
Recently in my code I have started getting the following warnings:
This PR updates the code to use
packaging.versionif it is available avoiding the warning. Also while I had the code there I fixed a few other tests and formatting issues.The three commits are:
collections.Hashabletocollections.abc.HashableHappy to split them into separate PRs if that would be better.
Cheers!
Hector