semantic text bulk inference integration test #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosdelest
commented
May 10, 2024
| @@ -27,14 +27,6 @@ | |||
|
|
|||
| public abstract class AbstractTestInferenceService implements InferenceService { | |||
|
|
|||
| protected static int stringWeight(String input, int position) { | |||
There was a problem hiding this comment.
Moved to specific methods on the different dense and sparse vector mock services
| @@ -43,8 +44,22 @@ public List<Factory> getInferenceServiceFactories() { | |||
| return List.of(TestInferenceService::new); | |||
| } | |||
|
|
|||
| public static class TestDenseModel extends Model { | |||
There was a problem hiding this comment.
Added mock models as well
carlosdelest
changed the title
|
Addressing merge into main in elastic#108550 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created an IT for bulk ingestion using semantic_text.
Base branch is the current open PR for ingestion. I'd prefer to merge that first before this one to avoid noise, and open it as a follow up.
I've done an IT that mixes bulk operations (index, update, upsert) on an index, and tests the number of documents in the index. I've relied heavily on randomness to get test coverage.