PR feedback

carlosdelest · Apr 16, 2024 · db36d14 · db36d14
1 parent 914ce1c
commit db36d14
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/...rence/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java b/...rence/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java
@@ -359,6 +359,7 @@ private static Mapper.Builder createEmbeddingsField(IndexVersion indexVersionCre
                     switch (similarity) {
                         case COSINE -> denseVectorMapperBuilder.similarity(DenseVectorFieldMapper.VectorSimilarity.COSINE);
                         case DOT_PRODUCT -> denseVectorMapperBuilder.similarity(DenseVectorFieldMapper.VectorSimilarity.DOT_PRODUCT);
+                        case L2_NORM -> denseVectorMapperBuilder.similarity(DenseVectorFieldMapper.VectorSimilarity.L2_NORM);
                         default -> throw new IllegalArgumentException(
                             "Unknown similarity measure in model_settings [" + similarity.name() + "]"
                         );
@@ -382,10 +383,6 @@ private static boolean canMergeModelSettings(
         if (previous == null) {
             return true;
         }
-        if (current == null) {
-            conflicts.addConflict("model_settings", "");
-            return false;
-        }
         conflicts.addConflict("model_settings", "");
         return false;
     }