PR feedback

carlosdelest · Mar 26, 2024 · ace17dd · ace17dd
1 parent 5c3d9c4
commit ace17dd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/...ce/src/main/java/org/elasticsearch/xpack/inference/mapper/InferenceResultFieldMapper.java b/...ce/src/main/java/org/elasticsearch/xpack/inference/mapper/InferenceResultFieldMapper.java
@@ -150,6 +150,7 @@ public InferenceResultFieldMapper() {
     protected void parseCreateField(DocumentParserContext context) throws IOException {
         boolean withinLeafObject = context.path().isWithinLeafObject();
         try {
+            // Disable dot expansion so there is no need to traverse subobjects for retrieving the field type
             context.path().setWithinLeafObject(true);
             XContentParser parser = context.parser();
             failIfTokenIsNot(parser, XContentParser.Token.START_OBJECT);

diff --git a/...ce/src/yamlRestTest/resources/rest-api-spec/test/inference/10_semantic_text_inference.yml b/...ce/src/yamlRestTest/resources/rest-api-spec/test/inference/10_semantic_text_inference.yml
@@ -337,9 +337,9 @@ setup:
         index: test-multifield-index
         id: doc_1
 
-  - match: { _source.top_level_field: "multifield inference test" }
-  - match: { _source._inference.top_level_field\.semantic_multifield.results.0.text: "multifield inference test" }
-  - exists: _source._inference.top_level_field\.semantic_multifield.results.0.inference
+  - match:  { _source.top_level_field: "multifield inference test" }
+  - length: { _source._inference.top_level_field\.semantic_multifield.results: 1 }
+  - match:  { _source._inference.top_level_field\.semantic_multifield.results.0.text: "multifield inference test" }
   - exists: _source._inference.top_level_field\.semantic_multifield.results.0.inference