spotless

carlosdelest · Jan 10, 2024 · 6ec089e · 6ec089e
1 parent 6034579
commit 6ec089e
Show file tree

Hide file tree

Showing 3 changed files with 47 additions and 47 deletions.
diff --git a/server/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java b/server/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java
@@ -157,7 +157,8 @@ public TransportBulkAction(
         IndexingPressure indexingPressure,
         SystemIndices systemIndices,
         LongSupplier relativeTimeProvider,
-        InferenceProvider inferenceProvider) {
+        InferenceProvider inferenceProvider
+    ) {
         this(
             BulkAction.INSTANCE,
             BulkRequest::new,
@@ -849,45 +850,46 @@ private void performInferenceOnBulkItemRequest(
                             @Override
                             public void onResponse(List<InferenceResults> results) {
 
-                            if (results == null) {
-                                throw new IllegalArgumentException(
-                                    "No inference retrieved for model ID " + modelId + " in document " + docWriteRequest.id()
-                                );
+                                if (results == null) {
+                                    throw new IllegalArgumentException(
+                                        "No inference retrieved for model ID " + modelId + " in document " + docWriteRequest.id()
+                                    );
+                                }
+
+                                int i = 0;
+                                for (InferenceResults inferenceResults : results) {
+                                    String fieldName = inferenceFieldNames.get(i++);
+                                    @SuppressWarnings("unchecked")
+                                    Map<String, Object> inferenceFieldMap = (Map<String, Object>) rootInferenceFieldMap.computeIfAbsent(
+                                        fieldName,
+                                        k -> new HashMap<String, Object>()
+                                    );
+
+                                    inferenceFieldMap.put(INFERENCE_FIELD, inferenceResults.asMap("output").get("output"));
+                                    inferenceFieldMap.put(TEXT_FIELD, docMap.get(fieldName));
+                                }
+
+                                docRef.close();
                             }
 
-                            int i = 0;
-                            for (InferenceResults inferenceResults : results) {
-                                String fieldName = inferenceFieldNames.get(i++);
-                                @SuppressWarnings("unchecked")
-                                Map<String, Object> inferenceFieldMap = (Map<String, Object>) rootInferenceFieldMap.computeIfAbsent(
-                                    fieldName,
-                                    k -> new HashMap<String, Object>()
+                            @Override
+                            public void onFailure(Exception e) {
+
+                                final String indexName = request.index();
+                                DocWriteRequest<?> docWriteRequest = request.request();
+                                BulkItemResponse.Failure failure = new BulkItemResponse.Failure(
+                                    indexName,
+                                    docWriteRequest.id(),
+                                    new IllegalArgumentException("Error performing inference: " + e.getMessage(), e)
                                 );
+                                responses.set(request.id(), BulkItemResponse.failure(request.id(), docWriteRequest.opType(), failure));
+                                // make sure the request gets never processed again
+                                bulkShardRequest.items()[request.id()] = null;
 
-                                inferenceFieldMap.put(INFERENCE_FIELD, inferenceResults.asMap("output").get("output"));
-                                inferenceFieldMap.put(TEXT_FIELD, docMap.get(fieldName));
+                                docRef.close();
                             }
-
-                            docRef.close();
-                        }
-
-                        @Override
-                        public void onFailure(Exception e) {
-
-                            final String indexName = request.index();
-                            DocWriteRequest<?> docWriteRequest = request.request();
-                            BulkItemResponse.Failure failure = new BulkItemResponse.Failure(
-                                indexName,
-                                docWriteRequest.id(),
-                                new IllegalArgumentException("Error performing inference: " + e.getMessage(), e)
-                            );
-                            responses.set(request.id(), BulkItemResponse.failure(request.id(), docWriteRequest.opType(), failure));
-                            // make sure the request gets never processed again
-                            bulkShardRequest.items()[request.id()] = null;
-
-                            docRef.close();
                         }
-                    });
+                    );
                 }
             }
         }

diff --git a/server/src/test/java/org/elasticsearch/action/bulk/TransportBulkActionInferenceTests.java b/server/src/test/java/org/elasticsearch/action/bulk/TransportBulkActionInferenceTests.java
@@ -313,18 +313,15 @@ private void expectInferenceRequest(String modelId, String... inferenceTexts) {
             List<String> texts = (List<String>) invocation.getArguments()[1];
             var listener = (ActionListener<List<InferenceResults>>) invocation.getArguments()[2];
             listener.onResponse(
-                        texts
-                            .stream()
-                            .map(
-                                text -> new TestInferenceResults(
-                                    "test_field",
-                                    randomMap(
-                                        1,
-                                        10,
-                                        () -> new Tuple<>(randomAlphaOfLengthBetween(1, 10), randomFloat())
-                                    )
-                                )
-                            ).collect(Collectors.toList()));
+                texts.stream()
+                    .map(
+                        text -> new TestInferenceResults(
+                            "test_field",
+                            randomMap(1, 10, () -> new Tuple<>(randomAlphaOfLengthBetween(1, 10), randomFloat()))
+                        )
+                    )
+                    .collect(Collectors.toList())
+            );
             return Void.TYPE;
         }).when(inferenceProvider)
             .textInference(eq(modelId), argThat(texts -> texts.containsAll(Arrays.stream(inferenceTexts).toList())), any());

diff --git a/server/src/test/java/org/elasticsearch/action/bulk/TransportBulkActionTookTests.java b/server/src/test/java/org/elasticsearch/action/bulk/TransportBulkActionTookTests.java
@@ -253,7 +253,8 @@ static class TestTransportBulkAction extends TransportBulkAction {
                 new IndexingPressure(Settings.EMPTY),
                 EmptySystemIndices.INSTANCE,
                 relativeTimeProvider,
-                null);
+                null
+            );
         }
     }
 }