Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fuzzy search #267

Merged
merged 4 commits into from
Feb 1, 2020
Merged

Conversation

adriencaccia
Copy link
Contributor

Description

Use fuzzy search.
This will for example make such a search possible:
image

Issue: #147

Tests

  • All tests passed.

@codecov
Copy link

codecov bot commented Dec 23, 2019

Codecov Report

Merging #267 into master will increase coverage by 1.42%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   86.42%   87.85%   +1.42%     
==========================================
  Files          20       21       +1     
  Lines         140      140              
  Branches       20       20              
==========================================
+ Hits          121      123       +2     
+ Misses         15       14       -1     
+ Partials        4        3       -1
Impacted Files Coverage Δ
src/utils/printEmojis.js 100% <ø> (ø) ⬆️
src/commands/commit/prompts.js 50% <0%> (+12.5%) ⬆️
src/commands/search/index.js 83.33% <100%> (-4.17%) ⬇️
src/utils/filterGitmojis.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7deeddb...a0a9853. Read the comment docs.

@adriencaccia
Copy link
Contributor Author

hey @carloscuesta, I moved the fuzzy filtering to a separate utils file and tested it, but the coverage diff is still not high enough 😢.
Do you have an idea on how to get it higher ?
Thanks !

Copy link
Owner

@carloscuesta carloscuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey!

Thanks for opening the PR, but as a general recommendation I would suggest you to read the contribution guide before opening any PR

🙏

package.json Outdated Show resolved Hide resolved
src/commands/search/index.js Outdated Show resolved Hide resolved
@adriencaccia
Copy link
Contributor Author

Thanks for the review !
Sorry I didn't follow the contributing guidelines before submitting the PR, I thought that since #147 existed you were waiting for someone to create it 😉.
I used fuse.js instead of fuzzy and cleaned the code a bit !

Copy link
Owner

@carloscuesta carloscuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@carloscuesta carloscuesta merged commit 0a6e97b into carloscuesta:master Feb 1, 2020
@ghost ghost mentioned this pull request Mar 10, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants