✨ Add TypeScript support #1125
Merged
✨ Add TypeScript support #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segersniels
force-pushed
the
maintenance/ts
branch
2 times, most recently
from
dbe9cfc to
fdecd67
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1125 +/- ##
==========================================
- Coverage 92.59% 91.90% -0.70%
==========================================
Files 29 28 -1
Lines 297 284 -13
Branches 69 69
==========================================
- Hits 275 261 -14
- Misses 21 22 +1
Partials 1 1
☔ View full report in Codecov by Sentry. |
segersniels
commented
Jun 14, 2023
Comment on lines
+20
to
+24
| ( | ||
| (meow as jest.Mock).mock.calls[0][1] as { importMeta: string } | ||
| ).importMeta = 'import.meta.url' | ||
|
|
||
| expect(meow.mock.calls).toMatchSnapshot() | ||
| expect((meow as jest.Mock).mock.calls).toMatchSnapshot() |
There was a problem hiding this comment.
Bit unfortunate bit of typing going on here, but not sure what the proper way would be to handle mocked libraries.
segersniels
force-pushed
the
maintenance/ts
branch
from
fdecd67 to
ea63d37
Compare
|
I guess we can eventually transition into using |
segersniels
force-pushed
the
maintenance/ts
branch
from
ea63d37 to
82004ee
Compare
|
I'll release a patch version with this! ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the project configuration to support TypeScript alongside Flow for a gradual conversion. The idea is to apply a boyscout rule to the codebase, if you touch a file, try to convert it to typescript as we go.
Added
tsconfig.jsonfile added for TypeScript configuration.@babel/preset-typescriptand TypeScript related devDependencies added.Changed
.tsextension.Issues