Skip to content

Commit

Permalink
Update to latest semconv table generator to fix int enum issue (open-…
Browse files Browse the repository at this point in the history
  • Loading branch information
arminru authored Mar 22, 2021
1 parent f969644 commit 402f73f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,4 @@ jobs:
steps:
- uses: actions/checkout@v1
- name: verify semantic convention tables
run: docker run --rm -v $(pwd)/semantic_conventions:/source -v $(pwd)/specification:/spec otel/semconvgen:0.3.0 -f /source markdown -md /spec --md-check
run: docker run --rm -v $(pwd)/semantic_conventions:/source -v $(pwd)/specification:/spec otel/semconvgen:0.3.1 -f /source markdown -md /spec --md-check
2 changes: 1 addition & 1 deletion semantic_conventions/syntax.md
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ array of booleans, or an enumeration. If it is an enumeration, additional fields
An enum entry has the following fields:

- `id`, string that uniquely identifies the enum entry.
- `value`, string, int, double, or boolean; value of the enum entry.
- `value`, string, int, or boolean; value of the enum entry.
- `brief`, optional string, brief description of the enum entry value. It defaults to the value of `id`.
- `note`, optional string, longer description. It defaults to an empty string.

Expand Down
2 changes: 1 addition & 1 deletion specification/trace/semantic_conventions/rpc.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ For remote procedure calls via [gRPC][], additional conventions are described in
<!-- semconv rpc.grpc -->
| Attribute | Type | Description | Examples | Required |
|---|---|---|---|---|
| `rpc.grpc.status_code` | number | The [numeric status code](https://github.com/grpc/grpc/blob/v1.33.2/doc/statuscodes.md) of the gRPC request. | `0`; `1`; `16` | Yes |
| `rpc.grpc.status_code` | int | The [numeric status code](https://github.com/grpc/grpc/blob/v1.33.2/doc/statuscodes.md) of the gRPC request. | `0`; `1`; `16` | Yes |

`rpc.grpc.status_code` MUST be one of the following:

Expand Down

0 comments on commit 402f73f

Please sign in to comment.