Skip to content

Commit

Permalink
Remove flush method on LogEmitter (open-telemetry#2405)
Browse files Browse the repository at this point in the history
Fixes open-telemetry#2342 

## Changes

This change proposes to remove the `flush` on Emitter for the consistency. There is no `flush` on Tracer/Meter specification. Language sdk implementations may choose the idiomatic way to provide the appender/handler ability to call flush on the `LogEmitterProvider` (ex: setter in [java](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/log4j/log4j-appender-2.16/library/src/main/java/io/opentelemetry/instrumentation/log4j/appender/v2_16/OpenTelemetryAppender.java#L86-L95), `init` arg in py, or possibly a global accessor for provider etc...)
  • Loading branch information
srikanthccv authored Mar 21, 2022
1 parent 87f9b77 commit 1e944ec
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ release.

### Logs

- Remove `flush` method on LogEmitter
([#2405](https://github.com/open-telemetry/opentelemetry-specification/pull/2405))

### Resource

### Semantic Conventions
Expand Down
2 changes: 0 additions & 2 deletions specification/logs/logging-library-sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ Methods:
e.g.
[Java discussion](https://github.com/open-telemetry/opentelemetry-java/pull/3759#discussion_r738019425))

- Flush.

### LogRecord

See LogRecord [data model](data-model.md) for the list of fields.
Expand Down

0 comments on commit 1e944ec

Please sign in to comment.