Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decoupling Dapper #24

Merged
merged 10 commits into from
Feb 20, 2023
Merged

Decoupling Dapper #24

merged 10 commits into from
Feb 20, 2023

Conversation

carl-berg
Copy link
Owner

@carl-berg carl-berg commented Feb 19, 2023 •
edited
Loading

Dapper is pretty great in general with backwards compatibility but if they were to release a new major version in the future, i would rather not have the dependency stopping downstream consumers from upgrading with releasing a new version of DataDude.

  • Updated ADatabaseFixture
  • Removed Dapper dependency and replaced sql command executions with raw ado executions.
  • Changed entry point of DataDude to be DbConnection/DbTransaction rather than IDbConnection/Detransition to ease making raw ado executions.
  • Changed target from netstandard2.0 to netstandard2.1 and changed Task types to ValueTask
  • Changed InstructionPreProcessor abstraction to InstructionDecorator to allow running both before and after instructions have run

@carl-berg carl-berg merged commit dcc542b into main Feb 20, 2023
@carl-berg carl-berg deleted the feature/dapper-decoupling branch February 20, 2023 10:57
@carl-berg carl-berg mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@carl-berg