Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/accelerometer unit conversion #234

Merged
merged 8 commits into from
Nov 18, 2024

Conversation

harshitha-batta
Copy link
Collaborator

This pull request adds a mutation script to convert iOS accelerometer data from G-forces to m/s², ensuring consistency with Android data units.

Updates include:

  • A mutation script for iOS to Android unit conversion.
  • Updated format.yaml configurations.
  • Adjustments to processed test data for consistency.

@harshitha-batta harshitha-batta changed the base branch from master to develop November 11, 2024 23:13
@harshitha-batta harshitha-batta force-pushed the feature/accelerometer-unit-conversion branch from 2f18ac4 to 878bc22 Compare November 12, 2024 22:17
@jenniferfedor jenniferfedor self-requested a review November 13, 2024 20:13
Copy link
Collaborator

@jenniferfedor jenniferfedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshitha0923 This looks great, thank you! My only suggested change is to preserve the empty line between sensors in the format.yaml files for consistency and readability. Could you also please update the change log in docs/? You can add a new section for v1.10.1 with separate bullet points for the accelerometer unit conversion and the updates to renv.lock. Thanks!

src/data/streams/aware_csv/format.yaml Show resolved Hide resolved
src/data/streams/aware_influxdb/format.yaml Show resolved Hide resolved
src/data/streams/aware_mysql/format.yaml Show resolved Hide resolved
@jenniferfedor jenniferfedor self-requested a review November 13, 2024 21:47
Copy link
Collaborator

@jenniferfedor jenniferfedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The convention for the change log is generally one relatively brief bullet per issue or feature, so I think we can combine some of the details of the accelerometer unit conversion into a single point. I think we can also clarify the description of the changes to renv.lock. You can add all of the suggestions for the format.yaml files and the change log to a batch and create a single commit with those changes from the “Files changed” tab!

docs/change-log.md Show resolved Hide resolved
docs/change-log.md Outdated Show resolved Hide resolved
docs/change-log.md Outdated Show resolved Hide resolved
docs/change-log.md Outdated Show resolved Hide resolved
docs/change-log.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@jenniferfedor jenniferfedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @harshitha0923! This level of detail is great to include in the description of your pull request. The change log is just a high level overview, so I think we can simplify a bit. Let me know if you have any questions about these suggestions.

docs/change-log.md Outdated Show resolved Hide resolved
Co-authored-by: Jennifer Fedor <[email protected]>
@jenniferfedor jenniferfedor merged commit 6cf60b9 into develop Nov 18, 2024
2 checks passed
@jenniferfedor jenniferfedor deleted the feature/accelerometer-unit-conversion branch November 18, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants