-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/accelerometer unit conversion #234
Conversation
2f18ac4
to
878bc22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harshitha0923 This looks great, thank you! My only suggested change is to preserve the empty line between sensors in the format.yaml files for consistency and readability. Could you also please update the change log in docs/
? You can add a new section for v1.10.1 with separate bullet points for the accelerometer unit conversion and the updates to renv.lock. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! The convention for the change log is generally one relatively brief bullet per issue or feature, so I think we can combine some of the details of the accelerometer unit conversion into a single point. I think we can also clarify the description of the changes to renv.lock. You can add all of the suggestions for the format.yaml files and the change log to a batch and create a single commit with those changes from the “Files changed” tab!
…nsistency and readability
Co-authored-by: Jennifer Fedor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @harshitha0923! This level of detail is great to include in the description of your pull request. The change log is just a high level overview, so I think we can simplify a bit. Let me know if you have any questions about these suggestions.
Co-authored-by: Jennifer Fedor <[email protected]>
This pull request adds a mutation script to convert iOS accelerometer data from G-forces to m/s², ensuring consistency with Android data units.
Updates include: