Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speedup git shallow cloning: Enable gix/max-performance #1186

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

NobodyXu
Copy link
Member

@NobodyXu NobodyXu commented Jun 29, 2023

for targets:

  • x86_64-apple-darwin
  • aarch64-apple-darwin
  • x86_64-unknown-linux-gnu
  • x86_64-unknown-linux-musl

which will use zlib-ng to speedup decompression and use assembly
version for sha1 checksum calculation on supported CPU.

Also enable feature zlib-ng on windows and

  • aarch64-unknown-linux-gnu
  • aarch64-unknown-linux-musl

Signed-off-by: Jiahao XU [email protected]

Motivation

#1184 adds e2e test that shallow clones the crates.io git index, which takes 11m just to clone the index in CI.

@NobodyXu NobodyXu marked this pull request as ready for review June 29, 2023 14:17
@NobodyXu NobodyXu marked this pull request as draft June 29, 2023 14:26
@NobodyXu NobodyXu added the Blocked: upstream Fix or feature is needed to be implemented upstream (in a dependency) label Jun 29, 2023
@NobodyXu

This comment was marked as outdated.

@NobodyXu

This comment was marked as outdated.

@NobodyXu
Copy link
Member Author

NobodyXu commented Jul 6, 2023

This PR now only enables gix/max-performancefor targets:

  • x86_64-apple-darwin
  • aarch64-apple-darwin
  • x86_64-unknown-linux-gnu
  • x86_64-unknown-linux-musl

@NobodyXu NobodyXu removed the Blocked: upstream Fix or feature is needed to be implemented upstream (in a dependency) label Jul 6, 2023
@NobodyXu NobodyXu force-pushed the speedup/gix branch 2 times, most recently from 76d2942 to 0e10f43 Compare July 6, 2023 14:54
@NobodyXu NobodyXu marked this pull request as ready for review July 6, 2023 14:57
@NobodyXu
Copy link
Member Author

NobodyXu commented Jul 6, 2023

I also enabled feature zlib-ng on windows and

  • aarch64-unknown-linux-gnu
  • aarch64-unknown-linux-musl

@NobodyXu NobodyXu requested a review from passcod July 6, 2023 15:32
@NobodyXu NobodyXu enabled auto-merge July 7, 2023 03:59
@NobodyXu NobodyXu added the PR: improvement PR that improves existing features or code label Jul 7, 2023
@NobodyXu NobodyXu added this pull request to the merge queue Jul 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2023
@NobodyXu NobodyXu added this pull request to the merge queue Jul 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2023
@NobodyXu NobodyXu added this pull request to the merge queue Jul 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2023
@NobodyXu NobodyXu added this pull request to the merge queue Jul 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2023
for targets:
 - x86_64-apple-darwin
 - aarch64-apple-darwin
 - x86_64-unknown-linux-gnu
 - x86_64-unknown-linux-musl

which will use `zlib-ng` to speedup decompression and use assembly
version for sha1 checksum calculation on supported CPU.

Also enable feature `zlib-ng` on windows and
 - aarch64-unknown-linux-gnu
 - aarch64-unknown-linux-musl

Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu NobodyXu added this pull request to the merge queue Jul 10, 2023
@NobodyXu
Copy link
Member Author

NobodyXu commented Jul 10, 2023

I keep getting:

+ cargo binstall --no-confirm [email protected]
 INFO resolve: Resolving package: 'cargo-watch@=8.4.0'
ERROR Fatal error:
  × For crate cargo-watch: I/O Error: unexpected EOF during skip
  ╰─▶ I/O Error: unexpected EOF during skip

when merging, they sometimes happen so I'm not sure whether it's a bug or just network failure.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 10, 2023
@NobodyXu NobodyXu added this pull request to the merge queue Jul 10, 2023
Merged via the queue into main with commit 9d46942 Jul 10, 2023
@NobodyXu NobodyXu deleted the speedup/gix branch July 10, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: improvement PR that improves existing features or code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants