Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The screen blinks before moving to another room #168

Closed
mapedorr opened this issue Mar 4, 2024 · 0 comments
Closed

The screen blinks before moving to another room #168

mapedorr opened this issue Mar 4, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@mapedorr
Copy link
Collaborator

mapedorr commented Mar 4, 2024

Bug description

Sometimes the screen blinks when changing from one room to another.

Steps to reproduce

  1. Create two rooms. Each one with a hotspot/prop that allows to move to the other room.
  2. Make the character walk to the clicked object and then face it before moving to the other room:
await C.walk_to_clicked()
await C.face_clicked()
E.goto_room("RoomNameHere") # or R.current = R.RoomNameHere
  1. After the first room transition, the screen will blink, from time to time, before fading out.

i167

Expected vs observed behavior

The screen should not blink during the fade out that plays before moving to another room.

Environment information (please complete):

  • OS type and version: Windows 11
  • Godot version: 4.2.1
  • Plugin version or branch: Beta 1

Additional context

The screen doesn't blink 100% of the times. In some cases I managed to reproduce the behavior only after waiting for a couple of seconds before moving to the other room.

If one removes the await C.face_clicked() its even harder to reproduce the issue. Perhaps it has to do with the fact that there are additional instructions before changing the room.

@mapedorr mapedorr added the bug Something isn't working label Mar 4, 2024
@mapedorr mapedorr self-assigned this Mar 4, 2024
mapedorr added a commit that referenced this issue Mar 5, 2024
The RESET animation is played at the beginning of each transition.

[upd] Improve the example comments of some script templates.
[upd] Change name of `item` parameter to `_item` in some script templates in order to avoid warnings.
[upd] 9 Verb GUI doesn't use the "active" cursor animation.
[fea] Popochiu clears the Hover text and changes the Cursor to its "normal" shape when changing room.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant