Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color-palette defaults #2059

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Conversation

burieberry
Copy link
Contributor

@burieberry burieberry commented Jan 17, 2025

Color Palette changes:

  • Add ability to remove color
  • Display selected color hex code
  • Set text color by default (black or white) based on selected background-color
palette-blog-category

Copy link

github-actions bot commented Jan 17, 2025

Host Test Results

    1 files  ±0      1 suites  ±0   21m 38s ⏱️ -1s
734 tests +1  732 ✔️ +1  2 💤 ±0  0 ±0 
738 runs  ±0  736 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit be6d4b8. ± Comparison against base commit 49ed00d.

This pull request removes 67 and adds 68 tests. Note that renamed tests count towards both.
Chrome 131.0 ‑ Acceptance | AI Assistant tests: attaches a card in a conversation multiple times
Chrome 131.0 ‑ Acceptance | AI Assistant tests: displays active LLM in chat input
Chrome 131.0 ‑ Acceptance | code submode | inspector tests > when the user lacks write permissions: delete button is not displayed for card instance when user does not have permission to write to realm
Chrome 131.0 ‑ Acceptance | code submode | inspector tests > when the user lacks write permissions: delete button is not displayed for misc file when user does not have permission to write to realm
Chrome 131.0 ‑ Acceptance | code submode | inspector tests > when the user lacks write permissions: delete button is not displayed for module when user does not have permission to write to realm
Chrome 131.0 ‑ Acceptance | code submode | inspector tests: "in-this-file" panel displays all elements and re-highlights upon selection
Chrome 131.0 ‑ Acceptance | code submode | inspector tests: "in-this-file" panel displays local grandfather card. selection will move cursor and display card or field schema
Chrome 131.0 ‑ Acceptance | code submode | inspector tests: "in-this-file" panel maintains selection after editing name of declaration
Chrome 131.0 ‑ Acceptance | code submode | inspector tests: After opening definition from card type and fields on RHS, "in-this-file" highlights selected definition
Chrome 131.0 ‑ Acceptance | code submode | inspector tests: After opening inherited definition inside inheritance panel, "in-this-file" highlights selected definition
…
Chrome 132.0 ‑ Acceptance | AI Assistant tests: attaches a card in a conversation multiple times
Chrome 132.0 ‑ Acceptance | AI Assistant tests: displays active LLM in chat input
Chrome 132.0 ‑ Acceptance | code submode | inspector tests > when the user lacks write permissions: delete button is not displayed for card instance when user does not have permission to write to realm
Chrome 132.0 ‑ Acceptance | code submode | inspector tests > when the user lacks write permissions: delete button is not displayed for misc file when user does not have permission to write to realm
Chrome 132.0 ‑ Acceptance | code submode | inspector tests > when the user lacks write permissions: delete button is not displayed for module when user does not have permission to write to realm
Chrome 132.0 ‑ Acceptance | code submode | inspector tests: "in-this-file" panel displays all elements and re-highlights upon selection
Chrome 132.0 ‑ Acceptance | code submode | inspector tests: "in-this-file" panel displays local grandfather card. selection will move cursor and display card or field schema
Chrome 132.0 ‑ Acceptance | code submode | inspector tests: "in-this-file" panel maintains selection after editing name of declaration
Chrome 132.0 ‑ Acceptance | code submode | inspector tests: After opening definition from card type and fields on RHS, "in-this-file" highlights selected definition
Chrome 132.0 ‑ Acceptance | code submode | inspector tests: After opening inherited definition inside inheritance panel, "in-this-file" highlights selected definition
…

♻️ This comment has been updated with latest results.

@burieberry burieberry force-pushed the cs-7848-color-palette-adjustments branch from c99b880 to 4255d1e Compare January 21, 2025 15:42
@burieberry burieberry marked this pull request as ready for review January 21, 2025 16:23
@burieberry burieberry requested a review from a team January 21, 2025 16:28
@burieberry burieberry merged commit 49c52ea into main Jan 21, 2025
50 checks passed
@jurgenwerk
Copy link
Contributor

Nice improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants