don't wait for ECS service stability for pg-migration deploy #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
habdelra
changed the title
habdelra
commented
Jan 8, 2025
| needs: [migrate-db] | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - run: sleep 240 |
There was a problem hiding this comment.
we still need to wait for the ECS task to be provisioned and start running. (the old action version actually just waited for the timeout of 5 minutes--i think we can do a little better than that)
|
This issue is holding up deployments so i'm going to merge now. I'll be happy to address any feedback after it's merged |
|
Seems good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we don't wait for ECS service stability for pg-migrations since it's not a service, just a task that needs to run in the same VPC--but the new ECS deploy GH action version gets mad that the service is not ready and exits with error status breaking the deploy. in the previous version of the GH action for ECS deploys, not having a heath check meant not waiting for the service to stabilize, but now we need to explicitly say it.